> On Aug. 18, 2014, 5:54 p.m., Ben Mahler wrote: > > Whoops, this change mixes stout / libprocess / mesos code! > > > > Probably our CHECK logic should eventually move inside a glog.hpp header as > > well to isolate the glog dependency in stout.
ping :) Looks like we should remove the extra include and add a namespace here, what do you think? :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24753/#review50799 ----------------------------------------------------------- On Aug. 15, 2014, 11:31 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24753/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 11:31 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1705 > https://issues.apache.org/jira/browse/MESOS-1705 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Also installed the handler in mesos tests to get stack traces for segfaults > we've been seeing lately. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb > 3rdparty/libprocess/3rdparty/stout/include/stout/logging.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/main.cpp > 75dbfec2cc58957a9dd099bfd79ee643f70a9a1a > 3rdparty/libprocess/src/tests/main.cpp > 934cb47540a1ad6ff6effe916831784f2b146e8b > src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea > src/tests/main.cpp 442be5109a941fc1db5b183c8e00add44e0cab68 > > Diff: https://reviews.apache.org/r/24753/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
