----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 -----------------------------------------------------------
First pass looks great. See Tim Chen's review too! include/mesos/mesos.proto <https://reviews.apache.org/r/25105/#comment90198> Let's use put the "units" at the end. Also, we can pull out read vs write: disk_read_total_iops disk_write_total_iops disk_read_total_bytes disk_write_total_bytes I like that the 'disk_' prefix matches the current resource name ("disk"), but I wonder if we want to use 'blk_' as the prefix instead, especially if we want to introduce new "disk" specific resources. src/slave/containerizer/isolators/cgroups/blkio.hpp <https://reviews.apache.org/r/25105/#comment90199> This doesn't compile. ;-) src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25105/#comment90191> Is there a reason to #ifdef this away? Like (most of) the other isolators, once this is in the code base we should always build it and let the operator decide whether or not they want ot use it. The network isolator is a bit more special case because it does a lot more. - Benjamin Hindman On Aug. 27, 2014, 5:59 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25105/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 5:59 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-350 > https://issues.apache.org/jira/browse/MESOS-350 > > > Repository: mesos-git > > > Description > ------- > > Currently there is no disk isolation in place and this affects an executor to > be starved of disk when another disk heavy operation such as copying a multi > gigabyte file is being performed by another executor. > > > Diffs > ----- > > include/mesos/mesos.proto dea51f9 > src/Makefile.am 40b9f6b > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 5116b14 > > Diff: https://reviews.apache.org/r/25105/diff/ > > > Testing > ------- > > In progress. > > > Thanks, > > Patrick Reilly > >
