----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24987/#review51888 -----------------------------------------------------------
Ship it! src/docker/docker.cpp <https://reviews.apache.org/r/24987/#comment90559> s/enabled/specified/ src/tests/docker_tests.cpp <https://reviews.apache.org/r/24987/#comment90560> No need to use resources right? src/tests/docker_tests.cpp <https://reviews.apache.org/r/24987/#comment90561> s/resources/None()/ - Jie Yu On Aug. 24, 2014, 5:04 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24987/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2014, 5:04 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1730 > https://issues.apache.org/jira/browse/MESOS-1730 > > > Repository: mesos-git > > > Description > ------- > > Fail when no command provided with shell enabled in docker > > > Diffs > ----- > > src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537 > src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953 > > Diff: https://reviews.apache.org/r/24987/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
