----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25207/#review51958 -----------------------------------------------------------
Patch looks great! Reviews applied: [25207] All tests passed. - Mesos ReviewBot On Aug. 29, 2014, 11:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25207/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 11:33 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1749 > https://issues.apache.org/jira/browse/MESOS-1749 > > > Repository: mesos-git > > > Description > ------- > > The bug was introduced when we did the merge of resourcesUnused and > resourcesRecovered (https://reviews.apache.org/r/24331/) > > It causes bugs like MESOS-1749. > > So should not create a filter if 'filters' is None(). But right now, we > always install a filter no matter what! > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52 > > Diff: https://reviews.apache.org/r/25207/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >