----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24810/#review52039 -----------------------------------------------------------
src/common/resources.cpp <https://reviews.apache.org/r/24810/#comment90766> use camelcase. s/last_range/lastRange/ src/common/resources.cpp <https://reviews.apache.org/r/24810/#comment90768> s/MergeFrom/CopyFrom/ src/tests/resources_tests.cpp <https://reviews.apache.org/r/24810/#comment90769> Instead of manually converting to ostringstream, just use "stringify()". Option<Value::Ranges> ports = r.ports(5); EXPECT_SOME(ports); EXPECT_EQ("[10000-10004]", stringify(ports.get())); src/tests/resources_tests.cpp <https://reviews.apache.org/r/24810/#comment90765> s/No/Not/ - Vinod Kone On Sept. 1, 2014, 3:26 a.m., Zuyu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24810/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 3:26 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1643 > https://issues.apache.org/jira/browse/MESOS-1643 > > > Repository: mesos-git > > > Description > ------- > > Added support to extract the given number of ports from the "ports" resources. > > > Diffs > ----- > > include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a > src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43 > src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2 > > Diff: https://reviews.apache.org/r/24810/diff/ > > > Testing > ------- > > make check GTEST_FILTER="*ResourcesTest*" > > > Thanks, > > Zuyu Zhang > >
