----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25275/#review52102 -----------------------------------------------------------
Fantastic - I don't know if you saw my work on this but i linked the bug (MESOS-1291) so you can see what direction i was going in. It's worth considering if this can be installed as a pre-commit hook. docs/clang-format.md <https://reviews.apache.org/r/25275/#comment90846> this is great! however, i think it's too much overhead to expect people to use it. for broad adoption we should stick to one version (probably 3.4) and update clang-format as new versions become available. i actually think we should hold off until 3.5 is more widely available so we get foreach wrapping correctly. support/clang-format-3.5 <https://reviews.apache.org/r/25275/#comment90844> I found BasedOnStyle: Chromium to give better results when I was playing with this. Did you see MESOS-1291? support/clang-format-mesos <https://reviews.apache.org/r/25275/#comment90845> the other option here is to persuade the powers that be that clang-format is the way forward and we should pick something close to the built-in that works with 3.5 (widely available?) or even 3.4 and go with that. - Dominic Hamon On Sept. 2, 2014, 4:04 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25275/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 4:04 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > Introduce ClangFormat which will > 1. reduce the amount of time we spend on formatting > 2. keep a consistent style across codebase > 3. reduce the amount of style-related issues that lengthen review cycles > > > Diffs > ----- > > .clang-format PRE-CREATION > .gitignore-template 3e2b11ca8a9f9e77f58718ae3425a983a24d5865 > docs/clang-format.md PRE-CREATION > support/clang-format-3.4 PRE-CREATION > support/clang-format-3.5 PRE-CREATION > support/clang-format-mesos PRE-CREATION > > Diff: https://reviews.apache.org/r/25275/diff/ > > > Testing > ------- > > Ran ClangFormat on the codebase. > > > Thanks, > > Michael Park > >
