----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25304/#review52209 -----------------------------------------------------------
Ship it! Ship It! - Jiang Yan Xu On Sept. 3, 2014, 10:21 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25304/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 10:21 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > Looking back through the commit history, this Option was introduced as a > dependency for some changes that were never committed. > > This complicates the resource accounting I need to do to prevent overcommit, > so I'm reverting the use of an Option here. > > > Diffs > ----- > > src/slave/http.cpp 39f840026595547c36f2c8b630ea8bcfc7b8dfbc > src/slave/slave.hpp 9d4607ef126f40ade9c861e3ea0eb41f10a3dff9 > src/slave/slave.cpp 5c76dd1b9d3f7d262053aa4c20ebc2e8a00a0f4e > > Diff: https://reviews.apache.org/r/25304/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
