----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25306/#review52224 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 3, 2014, 5:41 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25306/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 5:41 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1714 > https://issues.apache.org/jira/browse/MESOS-1714 > > > Repository: mesos-git > > > Description > ------- > > Currently, the C++ Resources class does not ensure that the underlying > Resources protobufs are kept flat. This is an issue because some of the > methods, e.g. Resources::get, assume the resources are flat. > > Until we fix MESOS-1714, we should prevent an unflattened construction of > Resources. > > > Diffs > ----- > > include/mesos/resources.hpp d7a9e8ad6a2bc49bd43bc2a7a40364b8e191ed59 > src/slave/slave.cpp 5c76dd1b9d3f7d262053aa4c20ebc2e8a00a0f4e > > Diff: https://reviews.apache.org/r/25306/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
