-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review52372
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25105/#comment91144>

    Single line comments.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25105/#comment91145>

    two spaces between methods. And all other places.



src/slave/containerizer/isolators/cgroups/blkio.cpp
<https://reviews.apache.org/r/25105/#comment91146>

    previous line



src/slave/containerizer/isolators/cgroups/blkio.cpp
<https://reviews.apache.org/r/25105/#comment91152>

    Format log.
    
    LOG(INFO) << "....."
              << "......";



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/25105/#comment91159>

    I'm not familiar with boost concept checks, but are you using it in your 
tests?



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/25105/#comment91153>

    pad with 4 spaces.



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/25105/#comment91156>

    previous line



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91137>

    Use single line comments, and this already exceeds 70 char.



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91142>

    two spaces in between methods.



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91141>

    formatting?



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91140>

    two spaces between methods.



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91139>

    two spaces between methods.



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91138>

    formatting.



src/common/resources.cpp
<https://reviews.apache.org/r/25105/#comment91143>

    two spaces in between methods.


- Timothy Chen


On Sept. 4, 2014, 11:01 p.m., Patrick Reilly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25105/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 11:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-350
>     https://issues.apache.org/jira/browse/MESOS-350
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently there is no disk isolation in place and this affects an executor to 
> be starved of disk when another disk heavy operation such as copying a multi 
> gigabyte file is being performed by another executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dea51f9 
>   include/mesos/resources.hpp 0e37170 
>   src/Makefile.am 5526189 
>   src/common/resources.cpp 29fc765 
>   src/linux/cgroups.hpp abf31df 
>   src/linux/cgroups.cpp 989e307 
>   src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 5116b14 
>   src/tests/isolator_tests.cpp c38f876 
> 
> Diff: https://reviews.apache.org/r/25105/diff/
> 
> 
> Testing
> -------
> 
> This now implements isolation at the read / write level, using both iops or 
> kbps. Tests for both are also included.
> 
> 
> Thanks,
> 
> Patrick Reilly
> 
>

Reply via email to