----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25193/#review52508 -----------------------------------------------------------
Ship it! Ship It! - Dominic Hamon On Aug. 29, 2014, 10:54 a.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25193/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 10:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-1744 > https://issues.apache.org/jira/browse/MESOS-1744 > > > Repository: mesos-git > > > Description > ------- > > Use compiler intrinsics for unreachable, exit, and abort > Makes the functions not need to pretend to return something while > still silencing the compiler warnings. > > > Diffs > ----- > > src/log/leveldb.cpp 2967a1f > src/log/network.hpp fc85a57 > src/slave/containerizer/mesos/launch.cpp 9819381 > src/tests/routing_tests.cpp 10730ad > src/zookeeper/zookeeper.cpp 72c9fc3 > > Diff: https://reviews.apache.org/r/25193/diff/ > > > Testing > ------- > > Make check runs. > > > Thanks, > > Patrick Reilly > >