> On Sept. 8, 2014, 6:02 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 2322 > > <https://reviews.apache.org/r/25373/diff/1/?file=679958#file679958line2322> > > > > Instead of having a mock gc executor and launching 2 tasks and pausing > > the gc's unschedule, can we just do: > > > > launch one task. > > > > drop _runTask() dispatch. > > > > force re-registration. > > > > is that not enough?
Much better, thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52611 ----------------------------------------------------------- On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25373/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:43 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1715 > https://issues.apache.org/jira/browse/MESOS-1715 > > > Repository: mesos-git > > > Description > ------- > > This test drops the _runTask dispatch to ensure a task remains pending during > re-registration. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > b0e74b94db8a68cd676569d42b2ccd120f12b9d3 > > Diff: https://reviews.apache.org/r/25373/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
