----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review52767 -----------------------------------------------------------
src/docker/docker.cpp <https://reviews.apache.org/r/25403/#comment91838> For posterity it would be great to leave a comment explaining why you always want to use --entrypoint (i.e., why our initial implementation was insufficient). ;-) A small comment and a link to the JIRA should be sufficient! src/docker/docker.cpp <https://reviews.apache.org/r/25403/#comment91836> Why not move this up above as well? - Benjamin Hindman On Sept. 5, 2014, 10:13 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25403/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 10:13 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1770 > https://issues.apache.org/jira/browse/MESOS-1770 > > > Repository: mesos-git > > > Description > ------- > > Override entrypoint when shell enabled in Docker > > > Diffs > ----- > > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > > Diff: https://reviews.apache.org/r/25403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
