----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/#review53222 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/25565/#comment92732> We do have a executorLost() callback now! Just send it already and fix MESOS-313? src/master/master.cpp <https://reviews.apache.org/r/25565/#comment92733> I think "absent in re-registration of slave" is a bit unclear for people reading this log line in master logs? How about "...possibly unknown to the slave"? I'm assuming you wanted to rephrase because slave could actually know it? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25565/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 2:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This adds a removeExecutor helper based on a TODO that I added awhile ago. > > Much like removeTask, removeExecutor will help avoid future resource > accounting bugs. I also cleaned up Master::finalize > > > Diffs > ----- > > src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 > src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 > > Diff: https://reviews.apache.org/r/25565/diff/ > > > Testing > ------- > > no functional change > > make check > > > Thanks, > > Ben Mahler > >
