> On Sept. 15, 2014, 7:34 p.m., Ian Downes wrote: > > Drive by question: what does this offer that can't already be done with > > Subprocess? Form is path, vector of args and pipe/path/fd for in/out/err.
Huh, I guess I should have familiarized myself a little bit more with the codebase before taking a bite at this. Discarding. - Kamil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/#review53360 ----------------------------------------------------------- On Sept. 14, 2014, 4:05 p.m., Kamil Domanski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25618/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2014, 4:05 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod > Kone. > > > Bugs: MESOS-1792 > https://issues.apache.org/jira/browse/MESOS-1792 > > > Repository: mesos-git > > > Description > ------- > > Adds an overload of os::shell that allows to run a command with stdin and/or > stdout substituted by file descriptors passed as parameters. > > This will allow to pipe a stream of data in and out of a process e.g. > directly from download to extraction, as proposed by Bernd Mathiske in > MESOS-1667. > > A unit test has been added. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 84ef49c > > Diff: https://reviews.apache.org/r/25618/diff/ > > > Testing > ------- > > cd 3rdparty/libprocess/ && make check > > > Thanks, > > Kamil Domanski > >
