----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/#review53528 -----------------------------------------------------------
src/docker/docker.hpp <https://reviews.apache.org/r/25523/#comment93215> From an interface perspective I'd prefer that we created an 'Image' abstraction just like we have 'Container', and have Docker::pull return Future<Image> where doing a discard on the future is equivalent to cancel. See https://reviews.apache.org/r/24588 for the initial but incomplete version that I had done before 0.20.0. - Benjamin Hindman On Sept. 11, 2014, 6:44 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25523/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 6:44 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25523 > > > Diffs > ----- > > src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a > src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 > > Diff: https://reviews.apache.org/r/25523/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >