----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25663/#review53558 -----------------------------------------------------------
src/master/detector.cpp <https://reviews.apache.org/r/25663/#comment93256> Any way to explicitly ignore the no node case? Here we're ignoring all failures, which is a bit scary, since it's not obvious why the more serious errors would be caught elsewhere. I haven't put a lot of thought into this, could we return a Future<Option<string> > data? Or should we consider wrapping our things in some kind of ZKOperation<string> which lets us look at the various error cases? Happy to chat further! - Ben Mahler On Sept. 15, 2014, 9:24 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25663/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 9:24 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1392 > https://issues.apache.org/jira/browse/MESOS-1392 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca > > Diff: https://reviews.apache.org/r/25663/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
