> On Sept. 17, 2014, 7:20 p.m., Ben Mahler wrote: > > Whoops, looks like the test fails for me. Since we need to fix it, can you > > split the patch while you're at it? > > > > I think the parsing needs to be more advanced to handle OSes with labels on > > the versions.
Not just labels, but also more than three components. Should we change the Version to support arbitrary number of components before pushing this change through? In this particular case, the version string has four components "2.6.44-LABEL.el5" and the current parser will fail even if there were no labels. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53766 ----------------------------------------------------------- On Sept. 17, 2014, 6:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25755/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 6:50 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Version is now the preferred way for managing releases/versions. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 02a1e5842110f87cb12a917e5dc5ccadb54faacb > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 84ef49c410a08d60f77131e05e8ecfc5ed825f38 > src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 > > Diff: https://reviews.apache.org/r/25755/diff/ > > > Testing > ------- > > Ran make check > > > Thanks, > > Kapil Arya > >
