> On Sept. 18, 2014, 11:14 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 120 > > <https://reviews.apache.org/r/25798/diff/1/?file=693978#file693978line120> > > > > std::endl?
std::endl is a flush + '\n'. Note the whole codebase only uses '\n' newlines, so this works well for now. If we wanted to support changing line endings based on platform, there would be a lot more infrastructure needed. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53889 ----------------------------------------------------------- On Sept. 18, 2014, 10:53 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25798/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 10:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Follow up from 25079. > Reduces compile time overall by ~1/3rd. > Move implementation of libprocess help into cpp file. > Use strings::join to refactor macro expansion that was injecting lots of > overhead even when the expanded functions were not used. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am edbe54b > 3rdparty/libprocess/include/process/help.hpp 4333b5b > 3rdparty/libprocess/src/help.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25798/diff/ > > > Testing > ------- > > make check on 3rdparty > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
