----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25801/#review53899 -----------------------------------------------------------
Patch looks great! Reviews applied: [25801] All tests passed. - Mesos ReviewBot On Sept. 18, 2014, 11:12 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25801/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11:12 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-184 > https://issues.apache.org/jira/browse/MESOS-184 > > > Repository: mesos-git > > > Description > ------- > > > Also cleaned up the example frameworks as part of this: > > --> logging statements and resource handling is made consistent. > --> slaves are started with set resources for consistency > > > Diffs > ----- > > src/examples/java/TestFramework.java > e01b27c6f03b79093e957e85cb3fb32a807ca790 > src/examples/low_level_scheduler_libprocess.cpp > 9e93bb4df4c2653616caa0351da2edb21c4b9c8e > src/examples/low_level_scheduler_pthread.cpp > a408571a0255194eed6115cf813da53e310460df > src/examples/no_executor_framework.cpp > 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 > src/examples/python/test_framework.py > 75ca5092d07789aa97e76c2224c86acf83e0d7e3 > src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 > src/tests/java_framework_test.sh 95a05a636ed74817f02d862a3863cb13285eb0d5 > src/tests/low_level_scheduler_libprocess_test.sh > eb1736ace5f20ba15c45d58fa263c9bc50876fd7 > src/tests/low_level_scheduler_pthread_test.sh > 839e8ebb80a4bdb21404c9d7e3c94b2973324284 > src/tests/no_executor_framework_test.sh > e8d72a3be80cc215576fbf3ecc58d7b25975c0b8 > src/tests/python_framework_test.sh a1e36dfd47e7e6a0d2a10382c410780dfe36391e > src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a > > Diff: https://reviews.apache.org/r/25801/diff/ > > > Testing > ------- > > make check GTEST_FILTER="*EXAMPLESTEST*" > > > Thanks, > > Vinod Kone > >
