----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/#review53904 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25567/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 9:30 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1410 > https://issues.apache.org/jira/browse/MESOS-1410 > > > Repository: mesos-git > > > Description > ------- > > This is the MESOS-1410 which fixes MESOS-1389. > > The idea here is that the master needs to hold on to those tasks that are > terminal, but have yet to be acknowledged by the scheduler. Otherwise, > reconciliation requests could lead to TASK_LOST updates **before** a > framework receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the > task. > > Now the master needs to: > (1) Remove tasks when an acknowledgement arrives. > (2) Recover resources when the task becomes terminal. > (3) Omit resources for terminal tasks in the http statistics. > > > Diffs > ----- > > src/master/master.hpp 80d753509be21614325b9492a078350d6cb6641c > src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 > > Diff: https://reviews.apache.org/r/25567/diff/ > > > Testing > ------- > > make check > > Added new tests in https://reviews.apache.org/r/25568/ > > > Thanks, > > Ben Mahler > >
