> On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: > > OK. I went through parts of this review but I have a bigger suggestion in > > mind, before I get too much into the weeds. > > > > I think it's worthwhile for you to write up a design doc similar to the > > framework info doc w.r.t. updating SlaveInfo. This will force you to think > > about the repercussions of changing each of the SlaveInfo fields on the > > Mesos stack (master/allocator/slave/tasks/executors). Are you game? > > Cody Maloney wrote: > I'll work on a design doc later today. Will let you know when I have it. > > Vinod Kone wrote: > are you still on track for the design doc?
Yes. I have a draft now which I'm getting a first sanity check on at the moment, hopefully will have that by Tuesday of next week. Once that is done I'll send it out to you, and then mesos-dev as a whole. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review53100 ----------------------------------------------------------- On Sept. 13, 2014, 12:33 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25525/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2014, 12:33 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod > Kone. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos-git > > > Description > ------- > > Allows attributes and resources to be set to a superset of what they were > previously on a slave restart. > > Incorporates all comments from: > https://issues.apache.org/jira/browse/MESOS-1739 > and the former review request: > https://reviews.apache.org/r/25111/ > > > Diffs > ----- > > src/Makefile.am 9b973e5 > src/common/attributes.hpp 0a043d5 > src/common/attributes.cpp aab114e > src/common/slaveinfo_utils.hpp PRE-CREATION > src/common/slaveinfo_utils.cpp PRE-CREATION > src/master/master.hpp b492600 > src/master/master.cpp d5db24e > src/slave/slave.cpp 1b3dc73 > src/tests/attributes_tests.cpp 240a8ca > src/tests/slave_tests.cpp 69be28f > > Diff: https://reviews.apache.org/r/25525/diff/ > > > Testing > ------- > > make check on localhost > > > Thanks, > > Cody Maloney > >