----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25863/#review54306 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp <https://reviews.apache.org/r/25863/#comment94390> Add a new line above? - Jie Yu On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25863/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 6:45 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Also, added os::getns(pid, ns) to get the namespace inode for comparisons > between pids' namespaces. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > db9766d70adb9076946cd2b467c55636fe5f7235 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > b6464de53c3873ecd0b62a08ca9aac530043ffb9 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb > 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp > 5278996f201a4a3d69282c1bd7b0d230d0f6cd39 > 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp > ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5 > src/slave/containerizer/isolators/network/port_mapping.cpp > 9248460caa558e43a2a7d237f6a37d43f0eeacb5 > > Diff: https://reviews.apache.org/r/25863/diff/ > > > Testing > ------- > > Added test to check a clone(NEW_PIDNS) results in a new pid namespace. > > > Thanks, > > Ian Downes > >
