----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25948/#review54336 -----------------------------------------------------------
Just FYI, libnl still only supports v1 idiag, which is not as flexible as v2, this is probably why Chi still got both IPv4 and IPv6 connections even if he specifies AF_INET. Anyway, we can always filter the dump by ourself, so not a big deal. - Cong Wang On Sept. 23, 2014, 6:57 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25948/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 6:57 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Bugs: Mesos-1808 > https://issues.apache.org/jira/browse/Mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see Summary. > > > Diffs > ----- > > configure.ac da61c29 > src/Makefile.am 9b973e5 > src/linux/routing/diagnosis/diagnosis.hpp PRE-CREATION > src/linux/routing/diagnosis/diagnosis.cpp PRE-CREATION > src/linux/routing/diagnosis/internal.hpp PRE-CREATION > src/linux/routing/internal.hpp dca0dc5 > src/tests/routing_tests.cpp 10730ad > > Diff: https://reviews.apache.org/r/25948/diff/ > > > Testing > ------- > > added a test to use the code path. > > > Thanks, > > Chi Zhang > >
