----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review54351 -----------------------------------------------------------
Ship it! Thanks so much Tim, this is a great cleanup! I'll fix the logical bugs and land this for you shortly. src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment94479> Missing the include for <process/owned> src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment94487> Looks like the double negatives were pretty tricky per the bug below, I'll rename this to 'disabled' to make it a bit clearer. src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment94488> This is a bug! Should be ||, not && src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment94489> || here as well - Ben Mahler On Sept. 23, 2014, 10:02 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25569/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 10:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25569 > > > Diffs > ----- > > src/tests/environment.cpp 2274251aaf653d83c2d03ef2186763978067a747 > > Diff: https://reviews.apache.org/r/25569/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
