----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54553 -----------------------------------------------------------
Ship it! src/linux/cgroups.cpp <https://reviews.apache.org/r/25864/#comment94733> Instead of CHECK, can you just fail the promise since interval is specified by the user. src/linux/cgroups.cpp <https://reviews.apache.org/r/25864/#comment94734> Instead of CHECK, can you just fail the promise since interval is specified by the user. src/linux/cgroups.cpp <https://reviews.apache.org/r/25864/#comment94735> 4 space indent please. src/linux/cgroups.cpp <https://reviews.apache.org/r/25864/#comment94738> I am a little against reusing the timedout function as it requires jumping in the source code while reading it. But it's up to you. - Jie Yu On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25864/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 11:39 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Polls cgroups.procs until no processes in the cgroup. Poll interval and > timeout can be specified. > > > Diffs > ----- > > src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf > src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 > > Diff: https://reviews.apache.org/r/25864/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
