----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25966/#review54641 -----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/25966/#comment94890> do we need to call destroy? how about improving cgroups::remove() to do recursive removal and just calling that here? src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/25966/#comment94887> Tests? - Vinod Kone On Sept. 23, 2014, 11:41 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25966/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 11:41 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Check if a container is running in a pid namespace and thus all processes can > be killed by the kernel, rather than using the freezer. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.cpp > f7bc894830a7ca3f55465dacc7b653cdc2d7758b > > Diff: https://reviews.apache.org/r/25966/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
