> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote: > > src/module/manager.cpp, line 173 > > <https://reviews.apache.org/r/25848/diff/5/?file=701887#file701887line173> > > > > You could probably stick the json parsing into a separate sub-class. > > I'm all for breaking out a small JIRA tree from the comments. > > Niklas Nielsen wrote: > Is it so we can discuss the format further or because we should address > this in different patches? > > Kapil Arya wrote: > I have created a new private function that does all the parsing. > Hopefully, that is more readable now.
+1. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54425 ----------------------------------------------------------- On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 11:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 > include/mesos/module.hpp.in PRE-CREATION > src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b > src/examples/test_module.hpp PRE-CREATION > src/examples/test_module_impl.cpp PRE-CREATION > src/examples/test_module_impl2.cpp PRE-CREATION > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
