> On Sept. 29, 2014, 6:17 a.m., Benjamin Hindman wrote: > > How much fine-tuning can we apply here? Between this and cpplint.py will we > > "cover" out style completely? Looking forward to helping make folks more > > productive but don't want to frustrate people that use this and then still > > get comments on their reviews about needing to make changes to be > > consistent with our style. :-/
one thing that i've seen happen in the past, is that any comments about style in reviews can be trivially dismissed as a bug against the clang-format specification. ie, reviews stop being about style nits at all but focus is instead on making clang-format more compliant (or allowing our style guide to mutate to match the clang-format one, alternatively). every version of clang-format adds more tweakable items, but it is worth considering keeping our exceptions limited to ease people coming from other code-bases. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/#review54806 ----------------------------------------------------------- On Sept. 29, 2014, 11:33 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26069/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 11:33 a.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and > Timothy Chen. > > > Bugs: MESOS-1291 > https://issues.apache.org/jira/browse/MESOS-1291 > > > Repository: mesos-git > > > Description > ------- > > We spend way too much of our time formatting, not to mention the amount of > time wasted during the review cycle to address style issues. Let’s get > ClangFormat to help us! > > If you don't know what ClangFormat is or how it works, take a look at the > Chandler Carruth's [live > demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to > 33m 27s. > > Further details and analysis are available > [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing). > > > Diffs > ----- > > .clang-format PRE-CREATION > support/clang-format PRE-CREATION > > Diff: https://reviews.apache.org/r/26069/diff/ > > > Testing > ------- > > Refer to the __Sample Diff__ section in the [Google > Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing) > > > Thanks, > > Michael Park > >
