----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26144/#review54875 -----------------------------------------------------------
Ship it! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/26144/#comment95190> Can you include a comment like the one above? // The framework does not use all the resources. - Ben Mahler On Sept. 29, 2014, 7:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26144/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 7:28 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1782 > https://issues.apache.org/jira/browse/MESOS-1782 > > > Repository: mesos-git > > > Description > ------- > > The test had 2 expectations on resourcesAllocated() at the end, but didn't > wait for the first one to be satisifed before setting up the more generic > second one. As a result, the 2nd one can end up capturing all the > resourcesAllocated() dispatches starving the 1st one. > > > Diffs > ----- > > src/tests/allocator_tests.cpp 9cd5da36daf144ba1c759003bc1376ce74833245 > > Diff: https://reviews.apache.org/r/26144/diff/ > > > Testing > ------- > > Ran the test 500 times in repetition. > > > Thanks, > > Vinod Kone > >
