----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/#review54882 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 9:01 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26149/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 9:01 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These have been deprecated since November 2013, at least Mesos 0.16. Should > be safe to remove at this point (People will have to upgrade pre-0.16 to > something between 0.16 and 0.20.1 inclusive, before upgrading past 0.20.1). > > commit 03b94076caddceda4c0a6a03aa44ebe4d64f1acc > Author: Benjamin Hindman <benjamin.hind...@gmail.com> > Date: Mon Nov 4 11:51:05 2013 -1000 > > Re-deprecated 'webui_hostname' as optional (from required). > > We still need to set the 'webui_hostname' field for now in order for > interoperating with code that expects it to be required (e.g., a slave > on an older release). After another deprecation cycle we can either > remove this field entirely or just keep it around as an artifact so > that we don't reuse the ID. > > Review: https://reviews.apache.org/r/15214 > > > > Diffs > ----- > > include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 > src/common/type_utils.cpp e55b1f9beb4c1b7aba2076ce2b15072fd8eec4e3 > src/master/registrar.cpp 3f9b9cf8ecc70e51fe41d3ac3993da1398571846 > src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed > > Diff: https://reviews.apache.org/r/26149/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
