> On Sept. 30, 2014, 9:16 p.m., Niklas Nielsen wrote: > > Vinod & Tobi: I can help out landing this if you are interested. I can't > > claim to be an angular expert though. > > > > One high-level comment: how about we write a test so we make sure it works > > in the future too? A simple framework register + parse state.json would do.
SGTM. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/#review55010 ----------------------------------------------------------- On Sept. 28, 2014, 4:28 a.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26125/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2014, 4:28 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1828 > https://issues.apache.org/jira/browse/MESOS-1828 > > > Repository: mesos-git > > > Description > ------- > > Allows frameworks to register a URL to its web UI. > > > Diffs > ----- > > include/mesos/mesos.proto be45494 > src/master/http.cpp 41d91c8 > src/webui/master/static/framework.html f6cce02 > src/webui/master/static/frameworks.html b11d71a > > Diff: https://reviews.apache.org/r/26125/diff/ > > > Testing > ------- > > Connected a framework with and without webui_url set and checked the web ui. > > > Thanks, > > Tobi Knaup > >
