----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26201/#review55144 -----------------------------------------------------------
Ship it! src/messages/messages.proto <https://reviews.apache.org/r/26201/#comment95528> File a ticket for this? - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26201/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:30 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The explicit SlaveID within ReregisterSlaveMessage is redundant: it is also > contained within the SlaveInfo. > > This follows up on the TODO to properly deprecate this. > > > Diffs > ----- > > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d > src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed > > Diff: https://reviews.apache.org/r/26201/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
