----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26202/#review55145 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26202/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:30 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1696 > https://issues.apache.org/jira/browse/MESOS-1696 > > > Repository: mesos-git > > > Description > ------- > > This is a short term approach to adding versioning, see MESOS-986 for the > long term approach. > > This is needed so that the master can differentiate slaves that support > reconciliation, in order to avoid requiring an additional upgrade phase as > part of the reconciliation changes. > > > Diffs > ----- > > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d > src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed > > Diff: https://reviews.apache.org/r/26202/diff/ > > > Testing > ------- > > make check. My later changes rely on this version being set correctly. > > > Thanks, > > Ben Mahler > >
