----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26206/#review55152 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/26206/#comment95533> s/no/no need for/ Can you also add a comment about why this doesn't need to go through the status update manager? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26206/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:31 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1696 > https://issues.apache.org/jira/browse/MESOS-1696 > > > Repository: mesos-git > > > Description > ------- > > The master must rely on the slave to reconcile tasks that were missing in the > re-registration message. Otherwise, the master may incorrectly send TASK_LOST > in the event of a race. > > See MESOS-1696 for further details. > > > Diffs > ----- > > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d > src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0 > src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed > src/tests/fault_tolerance_tests.cpp > e8f532232c091849489971d7fc96ae615ffb6de0 > > Diff: https://reviews.apache.org/r/26206/diff/ > > > Testing > ------- > > make check, and modified the test that captured the TASK_LOST case. Added > another test in a subsequent review. > > > Thanks, > > Ben Mahler > >