> On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4293 > > <https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293> > > > > hmmm. slave->used() doesn't really tell what is being returned here. > > how about calling it slave->resources() instead. do you think that's less > > confusing? > > > > slave->resources() # used resources. > > > > slave->info.resources() # total resources.
yea. not a big deal. that's why didn't raise an issue. s/used/allocated/ sounds good though, unless 'used' is already used in that context elsewhere. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55156 ----------------------------------------------------------- On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26199/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:30 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This avoids the need for the per-framework resource accounting in addTask, > which is error prone given it may diverge from the slave->used(). > > Rather, have Slave::used just return this mapping directly. > > > Diffs > ----- > > src/master/http.cpp 41d91c842456b6d8e23b45be24210c966c287e24 > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > > Diff: https://reviews.apache.org/r/26199/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
