----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26273/#review55477 -----------------------------------------------------------
I agree with Ben. I think we prefer adaptors such as `boost::adaptors::reverse` here so we can compose them. Another thing to consider is looking ahead to adopting more C++11 constructs into Mesos. It's a trivial transformation to modernize the `foreach` macro to `range-based for-loop`, but modernizing `reverseforeach` would be non-trivial as we need to also modify the container somehow. Using `foreach` + an adaptor would keep the transformation trivial. - Michael Park On Oct. 2, 2014, 6:15 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26273/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 6:15 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Define reverseforeach from Boost. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp > 0739d6360464873533af07e67f6beb7804af43aa > > Diff: https://reviews.apache.org/r/26273/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >