----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review55772 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26436/#comment96166> I've seen the pattern such as: `usage` -> `_usage` -> `__usage` for sequence of continuation functions. It doesn't seem like `__usage` in this case is actually a continuation function, but rather a refactoring of common code path. Maybe it should be named something else? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26436/#comment96167> Are these checks necessary? In both calls to `__usage` directly rather than through `defer` or something similar. - Michael Park On Oct. 8, 2014, 4:51 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26436/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 4:51 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26436 > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 > > Diff: https://reviews.apache.org/r/26436/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
