----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review55936 -----------------------------------------------------------
Bad patch! Reviews applied: [26382] Failed command: ./support/mesos-style.py Error: Checking 518 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/sched/sched.cpp:856: Lines should very rarely be longer than 100 characters [whitespace/line_length] [4] src/sched/sched.cpp:874: Lines should be <= 80 characters long [whitespace/line_length] [2] Total errors found: 2 - Mesos ReviewBot On Oct. 9, 2014, 1:18 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26382/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 1:18 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1, MESOS-1830 and MESOS-343 > https://issues.apache.org/jira/browse/MESOS-1 > https://issues.apache.org/jira/browse/MESOS-1830 > https://issues.apache.org/jira/browse/MESOS-343 > > > Repository: mesos-git > > > Description > ------- > > Annotating every TASK_LOST with comments to open discussion. > > If we add a 'source' field and consider adding TASK_INVALID i think it adds > much more information. I don't think the metrics would have to change as the > source matches the source file, I think. Unless I missed a subtlety. Ie, some > of the master TASK_LOST could be set to slave source, but i think it's > debatable. > > > Diffs > ----- > > src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f > src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8 > src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6 > src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 > > Diff: https://reviews.apache.org/r/26382/diff/ > > > Testing > ------- > > > Thanks, > > Dominic Hamon > >
