> On Sept. 27, 2014, 1:17 a.m., Adam B wrote:
> > src/master/master.cpp, line 3173
> > <https://reviews.apache.org/r/25184/diff/2/?file=681985#file681985line3173>
> >
> >     Update Brenden's TODO, since you're now wiping the data field.
> >     I'm not sure if we really want to wipe the message field, especially 
> > for terminal states that could be monitored by an external process (not the 
> > framework).
> 
> Timothy Chen wrote:
>     Is the message field being used at all though?

I didn't go through message field yet, I think it's fine to let this patch 
focus on data field because it did introduced problems.


- Chengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/#review54698
-----------------------------------------------------------


On Oct. 9, 2014, 10 p.m., Chengwei Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25184/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 10 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1746
>     https://issues.apache.org/jira/browse/MESOS-1746
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There was a bug found that Spark use TaskStatus.data to transfer computed
> result and mesos-master RES memory keeps increasing fast and finally will be
> killed by OOM killer.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d 
> 
> Diff: https://reviews.apache.org/r/25184/diff/
> 
> 
> Testing
> -------
> 
> tested with spark
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Reply via email to