----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26513/#review56043 -----------------------------------------------------------
Ship it! Looks good! Will get this committed for you shortly - Niklas Nielsen On Oct. 9, 2014, 12:59 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26513/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 12:59 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Module manager should return error on encountering a duplicate module name > (i.e. if a module with the same name has already been loaded). > > > Diffs > ----- > > src/module/manager.cpp 72041c06b28191dea244a39ba99666e53198decc > src/tests/module_tests.cpp 6f9ee33f2f2d41dcc5bde9ef6326186f56e7c7fc > > Diff: https://reviews.apache.org/r/26513/diff/ > > > Testing > ------- > > Added a test with duplicate modules; ran make check. > > > Thanks, > > Kapil Arya > >
