----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56173 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26533/#comment96494> Bring { down on newline 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26533/#comment96495> Same here 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26533/#comment96493> I know that nullptr is the advised way from the Google Style Guide - but we use the C-style NULL. Let's use that here and do a scan for all cases (when/if we agree on the move) 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26533/#comment96497> Same here - Niklas Nielsen On Oct. 9, 2014, 6:02 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26533/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 6:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Introduce a finalize() function to match the initialize() function in > process.hpp. Use this at the unit test runner for libprocess to start getting > more valuable valgrind feedback. > - Added cleanup of remaining Processes in ~ProcessManager() as a start. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp 270ca28 > 3rdparty/libprocess/src/process.cpp d30ed63 > 3rdparty/libprocess/src/tests/main.cpp 0a3ba4e > > Diff: https://reviews.apache.org/r/26533/diff/ > > > Testing > ------- > > make check > support/mesos-style > valgrind 3rdparty/libprocess/tests (to see a reduction in definitely lost > blocks) > > > Thanks, > > Joris Van Remoortere > >
