> On Oct. 8, 2014, 5:26 p.m., Vinod Kone wrote: > > Sorry for the delay in committing this. Since we didn't do a proper > > deprecation, I'm waiting for some of Twitter's clusters to get updated > > (i.e., removing --checkpoint from slave config files) before landing this > > on trunk. > > > > Let me know if there is an urgency in landing this patch and we'll figure > > out how to fast track it or do a proper deprecation.
IIUC, given that this flag has defaulted to the correct value for a while there shouldn't need to be a delay to commit this patch. If a particular organization's deployment breaks because it's still explicitly specifying this flag it'll find out very quickly at start time right? We can just add a note to UPDATING that users should remove the flag before upgrading to 0.21.0 from 0.20.0. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55918 ----------------------------------------------------------- On Oct. 6, 2014, 11:50 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26275/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 11:50 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-444 > https://issues.apache.org/jira/browse/MESOS-444 > > > Repository: mesos-git > > > Description > ------- > > Checkpointing has been enabled by default in the slave since 0.14, remove the > flag now because all slaves should checkpoint. > > Removing checkpoint from slaves throughout the codebase will occur in a > series of following commits. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2 > > Diff: https://reviews.apache.org/r/26275/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 with gcc. > > > Thanks, > > Cody Maloney > >
