> On Oct. 1, 2014, 5:45 p.m., Jie Yu wrote: > > src/state/log.cpp, lines 363-367 > > <https://reviews.apache.org/r/24536/diff/3/?file=708156#file708156line363> > > > > Could you please add a comment about why you wanna skip snapshots with > > diffs (it's not obvious to me)? > > > > Also, could you also comment on why this won't cause garbage collection > > issue? For example, what if all snapshots have diffs > 0?
I updated the comment and added a TODO to discuss how to introduce compaction and defragmentation. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/#review55028 ----------------------------------------------------------- On Oct. 12, 2014, 5:14 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24536/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2014, 5:14 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 > src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION > src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION > src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad > src/state/log.hpp 6bd054fcd1cf79a2ad1a59da59c9a903cb25882f > src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a > > Diff: https://reviews.apache.org/r/24536/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
