> On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote: > > Why not do it the same way that 'update' does it? > > Timothy Chen wrote: > It's pretty much the same, except I named the last method containerUsage > instead of __usage, based on Mpark's comment since it's not a true deferred > continuation method. > > Benjamin Hindman wrote: > Neither is __update. Just FYI for folks, we've also used the _ prefix to > identify where we can construct lambdas that can be locally scoped. More > importantly, however, the value in matching 'update' is because having > consistent patterns makes it easier for people to understand the code when > debugging or refactoring.
Make sense, I was confused a bit as well. Let me change it back - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review56301 ----------------------------------------------------------- On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26436/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 3:56 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26436 > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 > > Diff: https://reviews.apache.org/r/26436/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
