> On Oct. 12, 2014, 6:56 p.m., Benjamin Hindman wrote: > > src/slave/main.cpp, lines 126-127 > > <https://reviews.apache.org/r/26509/diff/9/?file=718287#file718287line126> > > > > When we can use EXIT(1) << please prefer it (see a few lines up for an > > example). Looks like you can clean up the same from your recent patch to > > src/master/main.cpp too!
It was me who recommend this, my bad - I was assuming that glog wouldnt like this without a prior initializing, hence trigger a warning. I checked it again and it doesnt do what I falsely remembered. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56357 ----------------------------------------------------------- On Oct. 11, 2014, 1:25 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26509/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2014, 1:25 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Added --module flag for Mesos slave. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/slave/main.cpp 1eafb356b58613d4ab8bd6dd245583e0d6f25a97 > > Diff: https://reviews.apache.org/r/26509/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
