----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review56714 -----------------------------------------------------------
src/docker/docker.cpp <https://reviews.apache.org/r/26736/#comment97097> Print the timeout value as well. src/docker/docker.cpp <https://reviews.apache.org/r/26736/#comment97096> You can use our to_string method (stringify) instead. src/docker/docker.cpp <https://reviews.apache.org/r/26736/#comment97104> Also, have you tried with the docker cli what's the exit status when you run docker stop if either 1) docker succesffully stopped 2) docker killed it in the end 3) can't do both src/docker/docker.cpp <https://reviews.apache.org/r/26736/#comment97098> Does docker stop -t 0 doesn't do this for you? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26736/#comment97102> You can just pass the duration value in. src/slave/flags.hpp <https://reviews.apache.org/r/26736/#comment97101> You're storing this as a duration type, so it actually takes a duration string instead of a number of seconds integer right? - Timothy Chen On Oct. 15, 2014, 10:58 a.m., Ryan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26736/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 10:58 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1925 > https://issues.apache.org/jira/browse/MESOS-1925 > > > Repository: mesos-git > > > Description > ------- > > Ensure docker calls stop if a docker_stop_timeout is provided Added the flag > docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill > will be run, otherwise a docker stop with the timeout in seconds is used. A > negative value will result in a Failure. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a > src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2 > src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/tests/docker_containerizer_tests.cpp > 67d60a885d65edbcbbf702bce83a54d1a5c0411f > src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba > > Diff: https://reviews.apache.org/r/26736/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose > support/mesos-style.py > > > Thanks, > > Ryan Thomas > >
