----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review56740 -----------------------------------------------------------
Patch looks great! Reviews applied: [26071] All tests passed. - Mesos ReviewBot On Oct. 15, 2014, 4:52 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26071/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 4:52 p.m.) > > > Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. > These modules are also hooked up to the relevant Isolator tests using the > typed test mechanism. It also paves the way for future integration with > custom modules specified on the command line. > > > Diffs > ----- > > src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 > src/examples/test_isolator_module.cpp PRE-CREATION > src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 > src/slave/containerizer/isolator.hpp > e52e8b15c740c62ef64b49897d3d6ae5179d4719 > src/slave/containerizer/isolators/posix.hpp > f120aafef96343d84f93c5636484509dc972a0a8 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/module.hpp PRE-CREATION > src/tests/module.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26071/diff/ > > > Testing > ------- > > make check with an Isolator module test. > > > Thanks, > > Kapil Arya > >
