----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26698/#review56754 -----------------------------------------------------------
Think Adam caught most issues. Only two small nits/questions src/slave/status_update_manager.cpp <https://reviews.apache.org/r/26698/#comment97141> Scan of s/> >/>>/ per new C++11 style src/slave/status_update_manager.cpp <https://reviews.apache.org/r/26698/#comment97142> Can you use stream->next() instead ? - Niklas Nielsen On Oct. 14, 2014, 11 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26698/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 11 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Added StatusUpdateManager::unacknowledged() API call so that slave can use > this info during reregistration. > > > Diffs > ----- > > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/slave/status_update_manager.hpp > 24e3882ad1969c20a64daf90e408618c310e9a81 > src/slave/status_update_manager.cpp > 5d5cf234ef2dd47fa4b1f67be761dbca31659451 > src/tests/status_update_manager_tests.cpp > e9ef1e208cb01535e9366db7872b922c8f06ec40 > > Diff: https://reviews.apache.org/r/26698/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
