----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26767/#review56797 -----------------------------------------------------------
Patch looks great! Reviews applied: [26766, 26767] All tests passed. - Mesos ReviewBot On Oct. 15, 2014, 6:46 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26767/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 6:46 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-1878 > https://issues.apache.org/jira/browse/MESOS-1878 > > > Repository: mesos-git > > > Description > ------- > > The new path::join logic introduced changed how paths showed up in > files/files.hpp. Specifically, it made it so that paths more rigorously had / > didn't have a leading '/' (were absolute). > > This caused some inconsistincies when trying to attach, detach, and resolve > paths, resulting in the files not being found, and therefore not showing up > in the webui. > > The fix is primarily to standardize all the path manipulation routines (See > review 26766), testing the round trip path thoroughly, then updating files to > use the helpers to always clean / sanitize the incoming paths so the fit into > the same pattern. > > This should resolve some lurking bugs around detach() as well. Unfortunately > I couldn't really add more tests there without changing the detach() return, > which was out of scope for this bugfix. > > > Diffs > ----- > > src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9 > src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa > src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 > > Diff: https://reviews.apache.org/r/26767/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
