----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26715/#review56880 -----------------------------------------------------------
Patch looks great! Reviews applied: [26715] All tests passed. - Mesos ReviewBot On Oct. 16, 2014, 1:09 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26715/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 1:09 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This patch allows us to use O_CLOEXEC even if it's not available on some > distributions. > > Will follow up with a patch to cleanup the code. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > ec41fe412290a152a15a49e091f0bc6436e42cfd > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 898d175980e397493270454aafdf340a96c9cf85 > > Diff: https://reviews.apache.org/r/26715/diff/ > > > Testing > ------- > > make check > > both on mac and linux > > > Thanks, > > Jie Yu > >